Skip to content

Conversation

@coastalwhite
Copy link
Collaborator

@coastalwhite coastalwhite commented Nov 13, 2025

Fixes #15287.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Nov 13, 2025
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.03%. Comparing base (add6bbf) to head (8b9260e).
⚠️ Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25327      +/-   ##
==========================================
+ Coverage   81.95%   82.03%   +0.08%     
==========================================
  Files        1712     1711       -1     
  Lines      237236   236904     -332     
  Branches     3011     3010       -1     
==========================================
- Hits       194422   194354      -68     
+ Misses      42041    41778     -263     
+ Partials      773      772       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ritchie46
Copy link
Member

I believe this was faster as it directly maps to the set kernels.

@coastalwhite
Copy link
Collaborator Author

The problem is that the set kernels don't work for many value / dtype combinations. I think I can just map it directly to .zip_with_same_dtype though.

@coastalwhite coastalwhite marked this pull request as draft November 14, 2025 08:20
@coastalwhite coastalwhite marked this pull request as ready for review November 14, 2025 08:50
@coastalwhite coastalwhite changed the title refactor: Dispatch Series.set to when.then.otherwise refactor: Dispatch Series.set to zip_with_same_dtype Nov 15, 2025
@orlp orlp merged commit 14db62e into pola-rs:main Nov 17, 2025
31 checks passed
@coastalwhite coastalwhite deleted the refactor/set-when-then branch November 17, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Series.set() results in NotImplementedType

3 participants