-
Notifications
You must be signed in to change notification settings - Fork 31
Add 2025_Lazaridis_IndoEuropeans #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2025_Lazaridis_IndoEuropeans #295
Conversation
|
Thanks for preparing this - looks very well done at first glance! The only thing I noticed is the I'll try to find a reviewer for the package. |
|
@martynamolak offered to review the package. Thank you! |
|
@thanks @Tlkhi for submitting this! janno file:
All the other files in the package seem ok as far as I could see. |
Thank you for your comments!
P.S: I will update the janno in the PR after fixing all the issues |
|
For what it's worth, I am OK with the suffixes... I think we have no official policy on this, and since the original authors haven't submitted the package, but @Tlkhi has, they get to decide. I believe since it's a Boston Paper, AADR-like suffixes make sense. Stephan |
|
Thanks for the review, @martynamolak, and thanks addressing it promptly, @Tlkhi. [1]. I think we can leave it like this in anticipation of the changes planned for Poseidon v3.0.0 as discussed here poseidon-framework/poseidon-schema#74 and more concretely here poseidon-framework/poseidon-schema#109 |
|
fixed the issues |
|
Perfect - thanks! Sorry for the long delay. Will merge now. |
PR Checklist for a new package submission
POSEIDON.ymlconforms to the general title structure suggested here:<Year>_<Last name of first author>_<Region, time period or special feature of the paper>, e.g.2021_Zegarac_SoutheasternEurope,2021_SeguinOrlando_BellBeakeror2021_Kivisild_MedievalEstonia.Poseidon_IDof the form<Original Poseidon_ID>_<Initials of the main author>_<Year>. Re-analysed versions ofI1685(Lazaridis et al. 2016) should, for example, be assigned the IDsI1685_IL22(Lazaridis et al. 2022) andI1685_IL25(Lazaridis et al. 2025).POSEIDON.ymlfile with not just the file-referencing fields, but also the following meta-information fields present and filled:poseidonVersion,title,description,contributor,packageVersion,lastModified(see here for their definition).jannofile (for a list of available fields look here and here for more detailed documentation about them)..bibfile with the necessary literature references for each sample in the.jannofile.POSEIDON.ymlfile and there are no additional, supplementary files in the submission that are not documented there..jannoand.bibfile are all named after the package title and only differ in the file extension.POSEIDON.ymlfile is1.0.0.poseidonVersionof the package in thePOSEIDON.ymlfile is set to the latest version of the Poseidon schema.POSEIDON.ymlfile contains the corresponding checksums for the fieldsgenoFile,snpFile,indFile,jannoFileandbibFile.CHANGELOGfile or one with a single entry for version1.0.0.Publicationcolumn in the.jannofile is filled and the respective.bibfile has complete entries for the listed mentioned keys..jannofile does not include any empty columns or columns only filled withn/a..jannofile adheres to the standard order as defined in the Poseidon schema here..jannoand the.ssffiles are not fully quoted, so they only use single- or double quotes ("...",'...') to enclose text fields where it is strictly necessary (i.e. their entry includes a TAB).trident validate --fullGeno.git lfs migrate import --no-rewrite path/to/file.bed(see here).