Skip to content

Conversation

@priyanshu-kun
Copy link
Contributor

@priyanshu-kun priyanshu-kun commented Jun 10, 2023

@vinitshahdeo @MikeRalphson
This pull request sets up a default Sails.js server in the src/server folder. The server project includes the necessary configuration files, such as config, api, as well as the required dependencies.

The purpose of this pull request is to provide a foundational structure for the Sails.js server, allowing for further development and integration or referencing with the existing dummy app. The default server setup offers the framework for developing and linking the needed functionality to the frontend.

Please review the changes and provide any feedback or suggestions for improvement.

@priyanshu-kun priyanshu-kun marked this pull request as draft June 10, 2023 07:10
Copy link

@MikeRalphson MikeRalphson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a few small issues.

Copy link
Contributor

@vinitshahdeo vinitshahdeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @priyanshu-kun

Let's keep your files inside the Dummy App folder. Keep it at the root-level. Please point your PR to the develop branch.

@priyanshu-kun priyanshu-kun deleted the gsoc-mentee-contribution branch June 15, 2023 15:32
@priyanshu-kun priyanshu-kun restored the gsoc-mentee-contribution branch June 15, 2023 15:37
@priyanshu-kun priyanshu-kun reopened this Jun 15, 2023
@priyanshu-kun priyanshu-kun changed the base branch from main to develop July 6, 2023 09:18
@priyanshu-kun priyanshu-kun marked this pull request as ready for review July 7, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants