Fix number bases other than 10 #90
Conversation
Currently the magic number is detected but the wrong value is shown This converts the number back to what the user is expecting eg 015 used to show Magic Number 12
src/Visitor/DetectorVisitor.php
Outdated
| $scalar instanceof LNumber && | ||
| $scalar->getAttribute('kind') != LNumber::KIND_DEC | ||
| )) { | ||
| $scalar->value = (int) base_convert( |
There was a problem hiding this comment.
in this case we are loosing base prefix (0 or 0b). Now dec 10 and binary 10 is displayed in the same way
There was a problem hiding this comment.
i would like more tests regarding this.
| public function test($input = 4) { | ||
| if ($input > 2) { | ||
| return 15; | ||
| return 015; |
There was a problem hiding this comment.
You think it should return 015 not 15 ?
There was a problem hiding this comment.
well if we a respecting base than yes. Also if we want to ignore number 0b10 but not dec 10 would it work?
There was a problem hiding this comment.
They are 2 separate numbers 0b10 would be ignored if you had 2 in the ignore list currently. so 0x2, 02, 2 and 0b1 would all be ignored by 2.. To get this to return like that we would need to add octal, hex and binary to the cases.
There was a problem hiding this comment.
Currently this happens for context
This PR makes it at least show 755
There was a problem hiding this comment.
You won't be able to tell the difference between 0755 and 0o755 with this
|
@sidz just updated this one too, shows 0755 as 0o755 now rather than 493 |
|
Hey @kubawerlos. |
4 participants
Currently the magic number is detected but the wrong value is shown
This converts the number back to what the user is expecting
eg 015 used to show Magic Number 12