Skip to content

Tooltip will be shown on bottom of the text if it's getting out of the window. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Tooltip will be shown on bottom of the text if it's getting out of the window. #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 26 additions & 23 deletions selection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,11 +193,23 @@ const Selection = (function() {
};
}

let isToolTipOnTop = true;
function setTooltipPosition() {
const position = selection.getRangeAt(0).getBoundingClientRect();
const DOCUMENT_SCROLL_TOP =
window.pageXOffset || document.documentElement.scrollTop || document.body.scrollTop;
top = position.top + DOCUMENT_SCROLL_TOP - iconsize - arrowsize;
window.pageYOffset ||
document.documentElement.scrollTop ||
document.body.scrollTop;
if (
position.top >=
iconsize /*the tooltip div's height is auto, content height will be equal to the iconsize*/
) {
top = position.top + DOCUMENT_SCROLL_TOP - iconsize - arrowsize;
isToolTipOnTop = true;
} else {
top = position.top + DOCUMENT_SCROLL_TOP + position.height + arrowsize;
isToolTipOnTop = false;
}
left = position.left + (position.width - iconsize * _icons.length) / 2;
}

Expand Down Expand Up @@ -234,27 +246,18 @@ const Selection = (function() {
div.appendChild(_icons.icons);

const arrow = document.createElement('div');
arrow.style =
'position:absolute;' +
'border-left:' +
arrowsize +
'px solid transparent;' +
'border-right:' +
arrowsize +
'px solid transparent;' +
'border-top:' +
arrowsize +
'px solid ' +
bgcolor +
';' +
'bottom:-' +
(arrowsize - 1) +
'px;' +
'left:' +
(iconsize * _icons.length / 2 - arrowsize) +
'px;' +
'width:0;' +
'height:0;';
arrow.style = `position:absolute;
border-left: ${arrowsize}px solid transparent;
border-right: ${arrowsize}px solid transparent;
border-top: ${arrowsize}px solid ${bgcolor};
${!isToolTipOnTop
? `top:-${arrowsize - 1}px;
transform: rotate(180deg);`
: `bottom:-${arrowsize - 1}px;`}
left:${(iconsize * _icons.length) / 2 - arrowsize}px;
width:0;
height:0;`;


if (!menu.disable) {
div.appendChild(arrow);
Expand Down