Core: move devicePixelRatio to dedicated library #13924
Conversation
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
modules/apstreamBidAdapter.js
Outdated
| const winDimensions = getWinDimensions(); | ||
| const width = winDimensions.screen?.width ?? window.screen?.width; | ||
| const height = winDimensions.screen?.height ?? window.screen?.height; | ||
| const devicePixelRatio = getDevicePixelRatio() ?? window.devicePixelRatio; |
Check warning
Code scanning / CodeQL
Access to window.devicePixelRatio
modules/hypelabBidAdapter.js
Outdated
| const uuid = uids[0] ? uids[0] : generateTemporaryUUID(); | ||
| const floor = getBidFloor(request, request.sizes || []); | ||
| const dpr = typeof window !== 'undefined' ? window.devicePixelRatio : 1; | ||
| const dpr = getDevicePixelRatio() ?? (typeof window !== 'undefined' ? window.devicePixelRatio : 1); |
Check warning
Code scanning / CodeQL
Access to window.devicePixelRatio
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
still discussing approximating this |
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
1 participant
related to #12060