Yandex Bid Adapter : add support for video ads #4004

DiMurer · 2025-06-06T13:35:46Z

🔧 Type of changes

✨ What's the context?

There are two updates for the Yandex adapter.

The аdapter now supports video banners.
The "displaymanager" and "displaymanagerver" fields have been added.

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🧪 Test plan

The tests were updated, too.

🏎 Quality check

Are your changes following our code style guidelines?
Are there any breaking changes in your code?
Does your test coverage exceed 90%?
Are there any erroneous console logs, debuggers or leftover code in your changes?

DiMurer · 2025-06-10T13:29:57Z

@osulzhenko fixed

AntoxaAntoxic · 2025-06-18T08:03:01Z

@DiMurer is it a port from PBS Go? Could you link a porting issue or a PR from PBS Go if any?

DiMurer · 2025-06-18T13:50:29Z

@AntoxaAntoxic
The merged PR is in Prebid.js: prebid/Prebid.js#13062
The same logic is used in PBS Go: prebid/prebid-server#4344

AntoxaAntoxic

please double-check the whole Go implementation and fix all the differences, and make the Java version functionally identical in that way

src/main/java/org/prebid/server/bidder/yandex/YandexBidder.java

osulzhenko · 2025-07-04T08:01:29Z

update required

osulzhenko · 2025-07-18T07:40:16Z

@DiMurer any updates on this one?

DiMurer · 2025-07-18T17:33:10Z

@osulzhenko
I will fix it in a couple of days. I made some changes to the Go adapter.

DiMurer · 2025-07-31T15:14:33Z

@AntoxaAntoxic @osulzhenko
I synced this PR with the Go repository. I added multiformat support and fixed previous issues.

src/main/java/org/prebid/server/bidder/yandex/YandexBidder.java

src/test/java/org/prebid/server/bidder/yandex/YandexBidderTest.java

src/main/java/org/prebid/server/bidder/yandex/YandexBidder.java

CTMBNara

There is some differences with GO version:

in yandex.yaml: usersync.redirect.url
I don't see such logic in GO:

        if (CollectionUtils.isEmpty(video.getMimes())) {
            videoBuilder.mimes(Collections.singletonList("video/mp4"));
        }

I don't see any logic related to the placement_id parameter that exists in GO.

Also, please, make a change according to this comment #4004 (comment)

This reverts commit e1ad64d.

DiMurer · 2025-09-05T15:28:35Z

@CTMBNara

in yandex.yaml:

If you mean the difference between an.yandex.ru and yandex.ru/an, they are aliases, but I synchronized them.
I'm not sure about the difference in parameters, such as {{gdpr}} vs. {{.GDPR}}. However, I believe they are correct.

I don't see such logic in GO:

In the Go PR, I was told that I was trying to fix an impossible problem because this logic was checked before the adapter code. So, I deleted it in the Go PR. If it's the same for Java, that's fine. I deleted it here, too.

I don't see any logic related to the placement_id parameter that exists in GO.

I'm a little confused. I didn't change any placement_id logic in my GO PR. Can we accept this part, about the video logic? I don't want to turn this PR into "add video support and synchronize all the logic between the repositories."

CTMBNara · 2025-09-15T22:25:10Z

@CTMBNara

in yandex.yaml:

If you mean the difference between an.yandex.ru and yandex.ru/an, they are aliases, but I synchronized them. I'm not sure about the difference in parameters, such as {{gdpr}} vs. {{.GDPR}}. However, I believe they are correct.

I don't see such logic in GO:

In the Go PR, I was told that I was trying to fix an impossible problem because this logic was checked before the adapter code. So, I deleted it in the Go PR. If it's the same for Java, that's fine. I deleted it here, too.

I don't see any logic related to the placement_id parameter that exists in GO.

I'm a little confused. I didn't change any placement_id logic in my GO PR. Can we accept this part, about the video logic? I don't want to turn this PR into "add video support and synchronize all the logic between the repositories."

Yes, thanks for the clarification.
video.mimes is a required field, so without it the initial request will fail validation. Therefore, yes, there is no need to set this field on the adapter side.
Yes, of course. I just pointed it out so that Yandex knows about the adapter differences between GO and Java.

CTMBNara · 2025-09-15T22:29:19Z

src/test/java/org/prebid/server/bidder/yandex/YandexBidderTest.java

Please change the order of all tests so that makeHttpRequest* tests come first, followed by makeBids* tests.

osulzhenko · 2025-09-26T08:21:19Z

update required

DiMurer · 2025-10-01T15:25:50Z

@CTMBNara
I changed the order of tests

CTMBNara

Please, remove this comments

CTMBNara · 2025-10-13T12:44:43Z

src/test/java/org/prebid/server/bidder/yandex/YandexBidderTest.java

        assertThatIllegalArgumentException().isThrownBy(() -> new YandexBidder("invalid_url", jacksonMapper));
    }

+    // ========== makeHttpRequest* tests ==========


CTMBNara · 2025-10-13T12:44:56Z

src/test/java/org/prebid/server/bidder/yandex/YandexBidderTest.java

+                        tuple("prebid.java", "1.1"));
+    }
+
+    // ========== makeBids* tests ==========


CTMBNara · 2025-10-13T12:45:05Z

src/test/java/org/prebid/server/bidder/yandex/YandexBidderTest.java

+        assertThat(result.getValue().getFirst().getType()).isEqualTo(video); // Video has highest priority
    }

+    // ========== Helper methods ==========


DiMurer · 2025-10-13T13:58:59Z

@CTMBNara done

osulzhenko assigned DiMurer Jun 10, 2025

DiMurer force-pushed the yandex-bid-adapter-add-support-video-ads branch from 00a9017 to dc3dec7 Compare June 10, 2025 13:10

osulzhenko requested a review from AntoxaAntoxic June 17, 2025 14:15

AntoxaAntoxic added the do not port label Jun 20, 2025

AntoxaAntoxic requested changes Jun 20, 2025

View reviewed changes

src/main/java/org/prebid/server/bidder/yandex/YandexBidder.java Show resolved Hide resolved

src/main/java/org/prebid/server/bidder/yandex/YandexBidder.java Show resolved Hide resolved

osulzhenko requested a review from AntoxaAntoxic July 29, 2025 09:56

DiMurer force-pushed the yandex-bid-adapter-add-support-video-ads branch from dc3dec7 to 3755550 Compare July 31, 2025 14:46

AntoxaAntoxic requested changes Aug 1, 2025

View reviewed changes

AntoxaAntoxic linked an issue Aug 6, 2025 that may be closed by this pull request

Port PR from PBS-Go: Yandex: Add video support #4117

Open

AntoxaAntoxic requested changes Aug 13, 2025

View reviewed changes

src/main/java/org/prebid/server/bidder/yandex/YandexBidder.java Outdated Show resolved Hide resolved

AntoxaAntoxic previously approved these changes Aug 18, 2025

View reviewed changes

DiMurer mentioned this pull request Aug 18, 2025

Yandex: Set referer and target-ref to site.page prebid/prebid-server#4488

Merged

osulzhenko requested a review from CTMBNara August 29, 2025 07:08

CTMBNara requested changes Sep 2, 2025

View reviewed changes

DiMurer added 8 commits September 5, 2025 17:48

Yandex Bid Adapter : add support for video ads

6762046

Fix test: resources request.json

ab53806

CR fix

f02bdd3

+video in bidder config

e3ee9b1

One more PR fix

7a25e60

fix header + tests

73efc5e

Revert "fix header + tests"

00613ef

This reverts commit e1ad64d.

PR fix

2db652e

DiMurer dismissed AntoxaAntoxic’s stale review via 2db652e September 5, 2025 15:25

DiMurer force-pushed the yandex-bid-adapter-add-support-video-ads branch from d694fce to 2db652e Compare September 5, 2025 15:25

CTMBNara requested changes Sep 15, 2025

View reviewed changes

Change test order

6aeb12a

DiMurer requested a review from CTMBNara October 2, 2025 15:38

Add empty line in the test file

5a2942e

CTMBNara previously approved these changes Oct 13, 2025

View reviewed changes

pr fix

aa80224

DiMurer dismissed CTMBNara’s stale review via aa80224 October 13, 2025 13:58

Yandex Bid Adapter : add support for video ads #4004

Are you sure you want to change the base?

Yandex Bid Adapter : add support for video ads #4004

Conversation

DiMurer commented Jun 6, 2025 • edited by marki1an Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔧 Type of changes

✨ What's the context?

🧠 Rationale behind the change

🧪 Test plan

🏎 Quality check

Uh oh!

DiMurer commented Jun 10, 2025

Uh oh!

AntoxaAntoxic commented Jun 18, 2025

Uh oh!

DiMurer commented Jun 18, 2025

Uh oh!

AntoxaAntoxic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

osulzhenko commented Jul 4, 2025

Uh oh!

osulzhenko commented Jul 18, 2025

Uh oh!

DiMurer commented Jul 18, 2025

Uh oh!

DiMurer commented Jul 31, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CTMBNara left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DiMurer commented Sep 5, 2025

Uh oh!

CTMBNara commented Sep 15, 2025

Uh oh!

CTMBNara Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

osulzhenko commented Sep 26, 2025

Uh oh!

DiMurer commented Oct 1, 2025

Uh oh!

CTMBNara left a comment

Choose a reason for hiding this comment

Uh oh!

CTMBNara Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

CTMBNara Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

CTMBNara Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

DiMurer commented Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

DiMurer commented Jun 6, 2025 •

edited by marki1an

Loading

CTMBNara left a comment •

edited

Loading