-
Notifications
You must be signed in to change notification settings - Fork 220
Support GET on the /vtrack endpoint #4073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@AntoxaAntoxic pls resolve a conflict |
# Conflicts: # src/test/java/org/prebid/server/metric/MetricsTest.java
updateCreativeMetrics( | ||
cachedCreatives, | ||
(ttl, type) -> metrics.updateVtrackCacheCreativeTtl(accountId, ttl, type), | ||
(size, type) -> metrics.updateVtrackCacheCreativeSize(accountId, size, type)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for lambdas, just pass accountId
as method argument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get, you mean it should be two separate updateCreativeMetrics
methods for vtrack and auction?
🔧 Type of changes
✨ What's the context?
prebid/prebid-server#3629
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check