SmileWanted endpoint now supports dynamic zoneId and integrates prebid server technology #4109

QuentinGallard · 2025-07-31T14:34:00Z

🔧 Type of changes

bid adapter update

✨ What's the context?

SmileWanted adapter needs to support dynamic endpoint URLs based on the zoneId parameter to align with our server infrastructure requirements.

🧠 Rationale behind the change

The SmileWanted bidder endpoint needs to be constructed dynamically using the zoneId from the impression extension. This change:

Allows SmileWanted to identify which Prebid Server technology (Go or Java) is making the request, enabling us to provide optimized responses for each implementation
Enables more efficient filtering of ad calls by including the zoneId directly in the URL path, improving request routing and performance

🧪 Test plan

Updated unit tests to verify zoneId extraction and proper error handling
Updated integration tests to use the new endpoint pattern
Tests verify that missing or invalid zoneId returns appropriate error messages
Endpoint construction follows the pattern used by other adapters with dynamic parameters

🏎 Quality check

Are your changes following our code style guidelines?
Are there any breaking changes in your code?
Does your test coverage exceed 90%?
Are there any erroneous console logs, debuggers or leftover code in your changes?

osulzhenko · 2025-08-15T07:29:27Z

@QuentinGallard Hi, is it still a draft?

QuentinGallard · 2025-08-19T12:27:35Z

Hi @osulzhenko,
Sorry, I was on summer holiday.
I rebased and fixed my pull request.
It is now waiting for approval.

The same pull request exists on Prebid Server Go project : prebid/prebid-server#4468

AntoxaAntoxic · 2025-08-29T10:33:37Z

src/test/resources/org/prebid/server/it/test-application.properties

 adapters.smartyads.endpoint=http://localhost:8090/smartyads-exchange
 adapters.smilewanted.enabled=true
-adapters.smilewanted.endpoint=http://localhost:8090/smilewanted-exchange
+adapters.smilewanted.endpoint=http://localhost:8090/smilewanted-exchange/java/


this change is unnecessary

AntoxaAntoxic · 2025-08-29T10:34:44Z

src/test/java/org/prebid/server/bidder/smilewanted/SmileWantedBidderTest.java

+    public void makeHttpRequestsShouldReturnSingleRequest() {
+        // given
+        final BidRequest bidRequest = BidRequest.builder()
+                .imp(singletonList(givenImp("zone123")))
+                .build();
+
+        // when
+        final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);
+
+        // then
+        assertThat(result.getErrors()).isEmpty();
+        assertThat(result.getValue()).hasSize(1);
+    }


I would also assert the payload and impIds sent to the bidder, also I'd created a bid request with at least two imps

AntoxaAntoxic · 2025-08-29T10:35:06Z

src/test/java/org/prebid/server/bidder/smilewanted/SmileWantedBidderTest.java

    @Test
-    public void makeHttpRequestsShouldCorrectlyAddHeaders() {
+    public void creationShouldFailOnNullEndpointUrl() {
+        assertThatNullPointerException().isThrownBy(() -> new SmileWantedBidder(null, jacksonMapper));
+    }
+
+    @Test
+    public void creationShouldFailOnNullMapper() {
+        assertThatNullPointerException().isThrownBy(() -> new SmileWantedBidder(ENDPOINT_URL, null));
+    }


those are kind of redundant, can be removed

AntoxaAntoxic · 2025-08-29T10:35:44Z

src/main/resources/bidder-config/smilewanted.yaml

 adapters:
  smilewanted:
-    endpoint: https://prebid-server.smilewanted.com
+    endpoint: https://prebid-server.smilewanted.com/java/


I would add a {{ZoneId}} macro instead of just appending zone Id to the end of the endpoint, please consider that

AntoxaAntoxic · 2025-08-29T10:36:34Z

src/main/java/org/prebid/server/bidder/smilewanted/SmileWantedBidder.java

+        if (CollectionUtils.isEmpty(request.getImp())) {
+            return Result.withError(BidderError.badInput("No impressions in request"));
+        }


this check is redundant

AntoxaAntoxic · 2025-08-29T10:36:57Z

src/main/java/org/prebid/server/bidder/smilewanted/SmileWantedBidder.java

        return Result.withValue(HttpRequest.<BidRequest>builder()
                .method(HttpMethod.POST)
-                .uri(endpointUrl)
+                .uri(url)
                .headers(createHeaders())
                .payload(outgoingRequest)
                .body(mapper.encodeToBytes(outgoingRequest))
                .build());
    }


please replace with the BidderUtil.defaultRequest()

AntoxaAntoxic · 2025-08-29T10:38:57Z

src/test/java/org/prebid/server/bidder/smilewanted/SmileWantedBidderTest.java

+                BidRequest.builder()
+                        .imp(singletonList(Imp.builder().id("123").build()))
+                        .build(),
+                mapper.writeValueAsString(


I would hide mapper.writeValueAsString inside the givenHttpCall

osulzhenko · 2025-09-08T07:08:35Z

@QuentinGallard any update?

AntoxaAntoxic · 2025-09-17T08:03:16Z

src/main/java/org/prebid/server/bidder/smilewanted/SmileWantedBidder.java

+        }
+
        final BidRequest outgoingRequest = request.toBuilder().at(DEFAULT_AT).build();
+        final String url = endpointUrl.replace("{{ZoneId}}", extImpSmilewanted.getZoneId());


please extract {{ZoneId}} as a constant

don't forget to add this macro to the URL in the smilewanted.json

AntoxaAntoxic · 2025-09-17T08:07:28Z

src/test/java/org/prebid/server/bidder/smilewanted/SmileWantedBidderTest.java

+                BidRequest.builder()
+                        .imp(singletonList(Imp.builder().id("123").build()))
+                        .build(),
+                mapper.writeValueAsString(


QuentinGallard · 2025-09-18T07:18:00Z

Hi @AntoxaAntoxic , the test that failed does not appear to be related to my changes and seems unstable to me.

What should I do now to get this Pull Request approved?

Thanks a lot for your time :)

AntoxaAntoxic · 2025-09-18T07:41:41Z

Hi @QuentinGallard

Thank you for the great PR.

Yes, the failed test is not related to your changes.

The PR will be merged after the 2nd approval closer to the next release date.

Thanks!

CTMBNara · 2025-09-19T09:42:42Z

src/test/java/org/prebid/server/bidder/smilewanted/SmileWantedBidderTest.java

+            final String body = bidResponse != null
+                    ? mapper.writeValueAsString(bidResponse)
+                    : mapper.writeValueAsString(null);
+            return givenHttpCall(bidRequest, body);


return givenHttpCall(bidRequest, mapper.writeValueAsString(bidResponse));

CTMBNara · 2025-09-19T09:47:27Z

src/main/java/org/prebid/server/bidder/smilewanted/SmileWantedBidder.java

+        }
+
        final BidRequest outgoingRequest = request.toBuilder().at(DEFAULT_AT).build();
+        final String url = endpointUrl.replace(ZONE_ID_MACRO, extImpSmilewanted.getZoneId());


add url encoding for zoneId

…d server technology

QuentinGallard force-pushed the sw_java_endpoint branch 2 times, most recently from 772729c to 2ab6d26 Compare August 1, 2025 08:06

osulzhenko assigned QuentinGallard Aug 15, 2025

QuentinGallard force-pushed the sw_java_endpoint branch from 885f378 to 60ef209 Compare August 19, 2025 09:33

QuentinGallard marked this pull request as ready for review August 19, 2025 12:23

QuentinGallard mentioned this pull request Aug 19, 2025

SmileWanted: Append zoneId to endpoint path prebid/prebid-server#4468

Merged

5 tasks

osulzhenko requested a review from AntoxaAntoxic August 29, 2025 07:07

AntoxaAntoxic requested changes Aug 29, 2025

View reviewed changes

QuentinGallard force-pushed the sw_java_endpoint branch 2 times, most recently from 1f73f2f to e664dc5 Compare September 15, 2025 12:06

AntoxaAntoxic requested changes Sep 17, 2025

View reviewed changes

QuentinGallard force-pushed the sw_java_endpoint branch from e664dc5 to 8d691c4 Compare September 17, 2025 12:57

AntoxaAntoxic previously approved these changes Sep 17, 2025

View reviewed changes

AntoxaAntoxic requested a review from CTMBNara September 18, 2025 07:41

CTMBNara requested changes Sep 19, 2025

View reviewed changes

QuentinGallard dismissed AntoxaAntoxic’s stale review via 44cb1d7 September 19, 2025 13:43

QuentinGallard force-pushed the sw_java_endpoint branch 2 times, most recently from 44cb1d7 to 4ba0336 Compare September 19, 2025 14:41

SmileWanted endpoint now supports dynamic zoneId and integrates prebi…

a97150e

…d server technology

QuentinGallard force-pushed the sw_java_endpoint branch from 4ba0336 to a97150e Compare September 19, 2025 14:51

CTMBNara approved these changes Sep 22, 2025

View reviewed changes

AntoxaAntoxic approved these changes Sep 25, 2025

View reviewed changes

AntoxaAntoxic linked an issue Sep 25, 2025 that may be closed by this pull request

Port PR from PBS-Go: SmileWanted: Append zoneId to endpoint path #4200

Open

AntoxaAntoxic added the do not port label Sep 25, 2025

SmileWanted endpoint now supports dynamic zoneId and integrates prebid server technology #4109

Are you sure you want to change the base?

SmileWanted endpoint now supports dynamic zoneId and integrates prebid server technology #4109

Conversation

QuentinGallard commented Jul 31, 2025

🔧 Type of changes

✨ What's the context?

🧠 Rationale behind the change

🧪 Test plan

🏎 Quality check

Uh oh!

osulzhenko commented Aug 15, 2025

Uh oh!

QuentinGallard commented Aug 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

osulzhenko commented Sep 8, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

QuentinGallard commented Sep 18, 2025

Uh oh!

AntoxaAntoxic commented Sep 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!