Skip to content

Conversation

AntoxaAntoxic
Copy link
Collaborator

@AntoxaAntoxic AntoxaAntoxic commented Aug 8, 2025

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

  • OMS, EMX Digital, IX, Adkernel and AudienceNetwork bidders require changes in their configuration due to lacking macros in their endpoints.
  • migrating from org.apache.httpcomponents.httpclient to org.apache.httpcomponents.client5.httpclient5
  • enhancing URL validation for bidder and any other endpoints

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@AntoxaAntoxic AntoxaAntoxic self-assigned this Aug 8, 2025
@AntoxaAntoxic AntoxaAntoxic added do not merge Not the time for merging yet do not port labels Aug 8, 2025
@osulzhenko osulzhenko requested a review from CTMBNara August 19, 2025 07:50
@osulzhenko osulzhenko added do not merge Not the time for merging yet and removed do not merge Not the time for merging yet labels Aug 29, 2025
@AntoxaAntoxic AntoxaAntoxic added PBS 4.0 and removed do not merge Not the time for merging yet labels Sep 4, 2025
@AntoxaAntoxic AntoxaAntoxic changed the title Bidder Configuration Fixes Bidder Configuration Fixes & URL Validation Sep 4, 2025
@osulzhenko
Copy link
Collaborator

@AntoxaAntoxic pls resolve a conflict

# Conflicts:
#	src/main/java/org/prebid/server/settings/HttpApplicationSettings.java
@AntoxaAntoxic AntoxaAntoxic added the do not merge Not the time for merging yet label Sep 26, 2025
@osulzhenko osulzhenko requested a review from And1sS September 30, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Not the time for merging yet do not port PBS 4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants