Module: Rules engine #4147
Open
Module: Rules engine #4147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ights not to sum up to less than 1.
# Conflicts: # extra/bundle/pom.xml # extra/modules/pom.xml
CTMBNara
requested changes
Sep 1, 2025
...c/main/java/org/prebid/server/hooks/modules/rule/engine/core/config/model/AccountConfig.java
Outdated
Show resolved
Hide resolved
...ain/java/org/prebid/server/hooks/modules/rule/engine/core/config/model/ModelGroupConfig.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/prebid/server/hooks/modules/rule/engine/core/config/model/RuleSetConfig.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/prebid/server/hooks/modules/rule/engine/core/config/model/AccountConfig.java
Outdated
Show resolved
Hide resolved
...er/hooks/modules/rule/engine/core/request/result/functions/filter/FilterBiddersFunction.java
Outdated
Show resolved
Hide resolved
...ks/modules/rule/engine/core/request/result/functions/filter/FilterBiddersFunctionConfig.java
Outdated
Show resolved
Hide resolved
...rver/hooks/modules/rule/engine/core/request/result/functions/filter/FilterBiddersResult.java
Outdated
Show resolved
Hide resolved
...ebid/server/hooks/modules/rule/engine/core/request/result/functions/log/AnalyticsMapper.java
Outdated
Show resolved
Hide resolved
...a/org/prebid/server/hooks/modules/rule/engine/core/rules/result/InfrastructureArguments.java
Outdated
Show resolved
Hide resolved
...engine/src/main/java/org/prebid/server/hooks/modules/rule/engine/core/util/WeightedList.java
Outdated
Show resolved
Hide resolved
CTMBNara
requested changes
Sep 2, 2025
...src/main/java/org/prebid/server/hooks/modules/rule/engine/core/config/StageConfigParser.java
Outdated
Show resolved
Hide resolved
# Conflicts: # extra/bundle/pom.xml # extra/modules/pom.xml
CTMBNara
previously approved these changes
Sep 16, 2025
...engine/src/main/java/org/prebid/server/hooks/modules/rule/engine/core/config/RuleParser.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
Context is described in public PRD: https://docs.google.com/document/d/1LcUkGfWL4aKFys0MRSNjKgo8NML2gS3VUtf1GQFKF_4/edit?tab=t.0
This is the first phase of the module, which includes all schema and result functions from prd, seat-non-bids, and analytics tags. For now, only account configuration is supported.
The implementation supports rule caching to reduce heavy-weight parsing. The following properties are available for cache configuration:
hooks.pb-rule-engine.rule-cache.expire-after-minutes- TTL for ruleshooks.pb-rule-engine.rule-cache.max-size- cache sizeSince broken configs are not cached and must be parsed on each request, a single broken config can significantly degrade PBS performance. To mitigate this, exponential backoff has been implemented for parsing. The following properties are available for backoff configuration:
hooks.pb-rule-engine.rule-parsing.retry-initial-delay-millis- initial delay in millisecondshooks.pb-rule-engine.rule-parsing.retry-max-delay-millis- maximum delay in millisecondshooks.pb-rule-engine.rule-parsing.retry-exponential-factor- backoff factorhooks.pb-rule-engine.rule-parsing.retry-exponential-jitter- jitter🧪 Test plan
Unit tests and funcitonal tests.
🏎 Quality check