Add github release action & migrate ossrh to central publishing #66
Conversation
unidevel
force-pushed
the
add_release_action
branch
from
586850a to
9647c13
Compare
unidevel
changed the title
| @@ -5,7 +5,7 @@ | |||
| <parent> | |||
| <groupId>com.facebook.airlift</groupId> | |||
| <artifactId>airbase</artifactId> | |||
| <version>98</version> | |||
| <version>107</version> | |||
There was a problem hiding this comment.
@imjalpreet FYI, to publish the maven artifacts we need upgrade airbase to 107+.
There was a problem hiding this comment.
Until now, I was upgrading to 105, which was required to bring in Java 17 changes, but I can change it to 107 if there are more changes that are required for publishing the artifacts.
There was a problem hiding this comment.
@unidevel, I kept my changes to upgrade to airbase 105 as it was required for Java 17. We can upgrade to 107 in this PR. Can you please help rebase on master to resolve conflicts?
unidevel
force-pushed
the
add_release_action
branch
from
9647c13 to
2e329e7
Compare
|
@imjalpreet resolved, please review, thanks. Tested with https://github.com/unix280/presto-hadoop-apache2/actions/runs/17740257657/job/50412197312, the 401 error should be fine since the test repo doesn't have the permission to publish |
pom.xml
Outdated
| <extensions>true</extensions> | ||
| <configuration> | ||
| <serverId>ossrh</serverId> | ||
| <nexusUrl>https://oss.sonatype.org/</nexusUrl> | ||
| <deploymentName>hadoop-apache2</deploymentName> |
There was a problem hiding this comment.
@unidevel, we just updated the artifactId to hadoop-apache. Can we update the deployment name here, too?
There was a problem hiding this comment.
Sure, let me update.
BTW, it is an internal name used by the publishing dashboard.
There was a problem hiding this comment.
updated as presto-hadoop-apache, so that we can easy to learn this deployment related to presto in the dashboard.
There was a problem hiding this comment.
Yes, just wanted to keep it consistent
unidevel
force-pushed
the
add_release_action
branch
from
2e329e7 to
58563ff
Compare
|
@tdcmeehan, can you please help merge this as well? We can publish a new release once this is merged. |
Add the release action to publish maven artifacts, require airbase version 107+.