Skip to content

Add github release action & migrate ossrh to central publishing #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add github release action & migrate ossrh to central publishing #66

wants to merge 1 commit into from

Conversation

unidevel
Copy link

@unidevel unidevel commented May 9, 2025 •
edited
Loading

Add the release action to publish maven artifacts, require airbase version 107+.

@unidevel unidevel force-pushed the add_release_action branch from 586850a to 9647c13 Compare July 30, 2025 09:34
@unidevel unidevel changed the title Add github release action Add github release action & migrate ossrh to central publishing Jul 30, 2025
unidevel
unidevel commented Jul 30, 2025
View reviewed changes
pom.xml
@@ -5,7 +5,7 @@
<parent>
<groupId>com.facebook.airlift</groupId>
<artifactId>airbase</artifactId>
<version>98</version>
<version>107</version>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imjalpreet FYI, to publish the maven artifacts we need upgrade airbase to 107+.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@unidevel I have included this change in #67 which upgrades this repo to Java 17

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until now, I was upgrading to 105, which was required to bring in Java 17 changes, but I can change it to 107 if there are more changes that are required for publishing the artifacts.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@unidevel, I kept my changes to upgrade to airbase 105 as it was required for Java 17. We can upgrade to 107 in this PR. Can you please help rebase on master to resolve conflicts?

@imjalpreet
Copy link
Member

@unidevel, once this PR is merged, can you please help publish a new release? I’ll update my Presto PR with the official dependency as soon as it’s available. Thanks!

@imjalpreet
Copy link
Member

@unidevel, can you please rebase and resolve the conflicts? Thanks!

We would need to publish a new release once the PR (#69) is merged.

@unidevel
Copy link
Author

unidevel commented Sep 15, 2025 •
edited
Loading

@imjalpreet resolved, please review, thanks.

Tested with https://github.com/unix280/presto-hadoop-apache2/actions/runs/17740257657/job/50412197312, the 401 error should be fine since the test repo doesn't have the permission to publish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdcmeehan tdcmeehan tdcmeehan approved these changes

+1 more reviewer

@imjalpreet imjalpreet imjalpreet approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@unidevel @imjalpreet @tdcmeehan