Skip to content

Conversation

@wanglinsong
Copy link
Member

No description provided.

@ZacBlanco
Copy link
Contributor

@wanglinsong can you apply this patch to the PR
docs.patch

@ZacBlanco
Copy link
Contributor

ZacBlanco commented Feb 11, 2025

Also, I noticed the CI failed. I think this may be due to GH actions recently updating the default nodejs version in their runners. We have the node version set explicitly in the actions/setup-node step

The action may need an update..

Copy link

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull branch and reviewed the HTML in the branch, starting at
file:///Users/steveburnett/Documents/GitHub/prestodb.github.io/website/static/docs/0.291/index.html

The 0.291 release notes are present, the headers say 0.291. Random sampling throughout the site showed me no problems with the docs in /website/static/docs/0.291/.

@steveburnett
Copy link

If you want me to pull and review again after @ZacBlanco's docs-patch is applied, just ask and I will look again.

yhwang and others added 2 commits February 11, 2025 13:07
Signed-off-by: Yihong Wang <[email protected]>
patch css and siteConfig.js
Copy link
Contributor

@ZacBlanco ZacBlanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yhwang , the PR looks good now

@alileclerc alileclerc merged commit f72b3e1 into prestodb:source Feb 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants