forked from HubSpot/hubspot-api-ruby
-
Notifications
You must be signed in to change notification settings - Fork 0
Add HubSpot API monkey-patch to skip blank hapikey #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
r-uehara0219
wants to merge
8
commits into
master
Choose a base branch
from
patch/oauth-skip-hapikey
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
133c62f
Add HubSpot API monkey-patch to skip blank hapikey and update gemspec…
r-uehara0219 4fb93de
Update JSON dependency version constraints in gemspec
r-uehara0219 373e327
Bump version to 9.5.1.trocco.0.0.2
r-uehara0219 c39a919
Add ffi runtime dependency and bump version to 9.5.1.trocco.0.0.6
r-uehara0219 41d0481
Add monkey-patch to skip blank hapikey in HubSpot API OAuth
r-uehara0219 3925759
Add patch to skip blank hapikey in HubSpot API and bump version to 9.…
r-uehara0219 f2aa927
Add monkey-patch to skip blank hapikey in OAuth and update version to…
r-uehara0219 f3bc77e
Update version to 9.5.1.trocco.0.0.10 and refine hapikey handling in …
r-uehara0219 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,3 +45,5 @@ def configure | |
end | ||
end | ||
end | ||
|
||
require_relative 'hubspot_patches/skip_hapikey' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
module Hubspot | ||
VERSION = '9.5.1' | ||
end | ||
VERSION = '9.5.1.trocco.0.0.10' | ||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
module Hubspot | ||
module SkipHapikeyPatch # :nodoc: | ||
def update_params_for_auth!(header, query, auth_names) | ||
filtered = Array(auth_names).reject do |name| | ||
name == 'hapikey' && | ||
(@config.access_token.to_s.strip != '' || | ||
@config.api_key['hapikey'].to_s.strip.empty?) | ||
end | ||
super(header, query, filtered) | ||
end | ||
end | ||
|
||
# CRM 配下にある全ての ApiClient に prepend | ||
module Crm | ||
constants.each do |sub| | ||
mod = const_get(sub) | ||
next unless mod.const_defined?(:ApiClient) | ||
|
||
mod::ApiClient.prepend SkipHapikeyPatch | ||
end | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(memo)ApiClientは例えば↓
https://github.com/primenumber-dev/hubspot-api-ruby/blob/master/lib/hubspot/codegen/crm/associations/api_client.rb