Skip to content

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Aug 25, 2025

Caution

Breaking changes expected. Need to migrate instances in github/github before merging this. This might be a really big task, so we'd need to see how much time do we want to give this as part of v38 tasks

Makes item.id required for FilteredActionList → SelectPanel
A common theme is that we still import types from deprecated/ActionList, swapping that to SelectPanel would make them more accurate

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@siddharthkp siddharthkp self-assigned this Aug 25, 2025
Copy link

changeset-bot bot commented Aug 25, 2025

🦋 Changeset detected

Latest commit: d7a6475

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Aug 25, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot requested a deployment to storybook-preview-6663 August 25, 2025 09:01 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6663 August 25, 2025 09:10 Inactive
@github-actions github-actions bot requested a deployment to storybook-preview-6663 August 25, 2025 09:54 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6663 August 25, 2025 10:08 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant