SelectPanel: Make item.id compulsory required #6663
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
Breaking changes expected. Need to migrate instances in github/github before merging this. This might be a really big task, so we'd need to see how much time do we want to give this as part of v38 tasks
Makes
item.id
required for FilteredActionList → SelectPanelA common theme is that we still import types from
deprecated/ActionList
, swapping that to SelectPanel would make them more accurateRollout strategy
Testing & Reviewing
Merge checklist