Skip to content

Conversation

@guorong009
Copy link
Collaborator

@guorong009 guorong009 marked this pull request as ready for review November 10, 2025 14:10
@guorong009 guorong009 self-assigned this Nov 10, 2025
@guorong009 guorong009 requested review from alxkzmn and brech1 November 10, 2025 14:10
Copy link
Member

@alxkzmn alxkzmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, let's just remove the word "example" from all the struct/variable/file names - it is an example in the context of the Binius64 repo but it's a legit standalone SHA-256 implementation in our context so we can simply call it a SHA-256 circuit or something.

@guorong009
Copy link
Collaborator Author

All good, let's just remove the word "example" from all the struct/variable/file names - it is an example in the context of the Binius64 repo but it's a legit standalone SHA-256 implementation in our context so we can simply call it a SHA-256 circuit or something.

Done 0a4392e

@guorong009 guorong009 requested a review from alxkzmn November 10, 2025 14:56
Copy link
Member

@alxkzmn alxkzmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guorong009 guorong009 merged commit 2a350cc into CSP-Q3-2025 Nov 11, 2025
6 checks passed
@guorong009 guorong009 deleted the binius64-native-optimization branch November 11, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable native optimizations for Binius64

4 participants