login-translation-bug

[Nishantkumar012]

Fixes #3339

Changes: I have added the translations for error invalid credentials in respective language

before:

After:

I have verified that this pull request:

• has no linting errors (npm run lint)
• has no test errors (npm run test)
• is from a uniquely-named feature branch and is up to date with the develop branch.
• is descriptively named and links to an issue number, i.e. Fixes #123

[welcome]

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

[cassiano]

Hello. Please take a look at my PR (#3593), where I used a script developed by me that checks this kind of problem for ANY LOCALE. With the help of the script, I have verified that most locales miss between 50 and 70 translations. Also, the script removes unused entries (dozens of it).

I will attach the newest version here. Please see instructions on how to use it in my PR.

p5js_editor_i18n_tools.ts

Cheers.

[cassiano]

I took the liberty to run the script for your specific locale (uk-UA):

deno --allow-read --allow-write p5js_editor_i18n_tools.ts ./p5.js-web-editor uk-UA SkipLink.PlaySketch

These are the (65) unused entries:

[
  "About.Learn",
  "About.Twitter",
  "AccountForm.SubmitSaveAllSettings",
  "AddToCollectionList.AnothersTitle",
  "AddToCollectionSketchList.AnothersTitle",
  "CodemirrorFindAndReplace.Find",
  "Collection.Description",
  "Collection.NumSketches_plural",
  "CollectionList.HeaderCreatedAt_mobile",
  "CollectionList.HeaderNumItems_mobile",
  "CollectionList.HeaderUpdatedAt_mobile",
  "CollectionView.TitleCreate",
  "CollectionView.TitleDefault",
  "Console.Close",
  "Console.Open",
  "CopyableInput.OpenViewTabARIA",
  "Explorer.Files",
  "Feedback.GoToForm",
  "Feedback.GoToGithub",
  "Feedback.ViaGithubDescription",
  "Feedback.ViaGithubHeader",
  "Feedback.ViaGoogleDescription",
  "Feedback.ViaGoogleHeader",
  "KeyboardShortcuts.CodeEditing.FindNextMatch",
  "KeyboardShortcuts.CodeEditing.FindPrevMatch",
  "LoginView.Email",
  "LoginView.Username",
  "MobileDashboardView.Assets",
  "MobileDashboardView.Collections",
  "MobileDashboardView.CreateCollection",
  "MobileDashboardView.CreateSketch",
  "MobileDashboardView.Examples",
  "MobileDashboardView.MyStuff",
  "MobileDashboardView.Sketches",
  "MobilePreferences.Accessibility",
  "MobilePreferences.AccessibleOutput",
  "MobilePreferences.AutocompleteHinter",
  "MobilePreferences.Autosave",
  "MobilePreferences.DarkTheme",
  "MobilePreferences.GeneralSettings",
  "MobilePreferences.HighContrastTheme",
  "MobilePreferences.LightTheme",
  "MobilePreferences.LineNumbers",
  "MobilePreferences.LintWarningSound",
  "MobilePreferences.PlainText",
  "MobilePreferences.Settings",
  "MobilePreferences.Sound",
  "MobilePreferences.TableText",
  "MobilePreferences.Theme",
  "MobilePreferences.UsedScreenReader",
  "MobilePreferences.WordWrap",
  "Nav.Auth.Asset",
  "Nav.Auth.My",
  "Nav.Auth.Welcome",
  "Nav.Lang",
  "NewPasswordView.EmptyPassword",
  "NewPasswordView.PasswordConfirmation",
  "NewPasswordView.PasswordMismatch",
  "Preferences.AddonOffARIA",
  "Preferences.AddonOnARIA",
  "Preferences.Sound",
  "Preferences.SoundOutputARIA",
  "SketchList.HeaderCreatedAt_mobile",
  "SketchList.HeaderUpdatedAt_mobile",
  "SketchList.View"
]

And this is the reviewed locale, where missing translations are properly annotated with a [NEEDS TRANSLATION <key>] marker, for a total of 67 in your case:

translations.reviewed.json

There you will see, among others, the translation which was the target of your own PR:

"Errors": {
  "invalidCredentials": "[NEEDS TRANSLATION - LoginForm.Errors.invalidCredentials] Invalid email or password."
}

Best regards.

[cassiano]

If Deno is not already installed in your system: https://deno.com/

MacOS/Linux: curl -fsSL https://deno.land/install.sh | sh
Windows: irm https://deno.land/install.ps1 | iex

I have only tested under MacOS, so be aware.

[Nishantkumar012]

@cassiano so I should translate the missing 67 translation which are missing??

[cassiano]

The answer is YES. But actually 66, since you have already translated the LoginForm.Errors.invalidCredentials one. Need a proof? After renaming it to translations.json inside the locales/uk-UA folder, locally navigate the editor itself with the generated locale file, go for example to the About page and see it for yourself, where all markers will be very explicitly shown in the page.

[raclim]

Thanks so much submitting this @Nishantkumar012 and for taking a look at this @cassiano!

Since the original attached issues is related to just the login page, I think for this specific pull request we can stick to the changes that have been submitted. I think the missing ones that @cassiano identified can be opened in a separate issue and pull request. Feel free @Nishantkumar012 to take that one on if you'd be interested in continuing with filling in the missing translations!

[cassiano]

@Nishantkumar012, like I mentioned:

[cassiano]

Thanks so much submitting this @Nishantkumar012 and for taking a look at this @cassiano!

Since the original attached issues is related to just the login page, I think for this specific pull request we can stick to the changes that have been submitted. I think the missing ones that @cassiano identified can be opened in a separate issue and pull request. Feel free @Nishantkumar012 to take that one on if you'd be interested in continuing with filling in the missing translations!

@raclim, I am sorry. I didn't mean @Nishantkumar012 was supposed to fix all remaining translations in his current PR. I simply answered his question regarding if the translations were actually needed.