p5.sound Nodes Default to Disconnected #61
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create P5SoundObject create P5SoundNode create P5SoundParameter create P5SoundSourceNode create P5SoundEffectNode create P5MixEffectNode convert existing nodes update imports create p5.AudioOutput remove old node files create P5SoundAnalyzerNode create P5SoundStartableSourceNode analysis nodes extend P5SoundAnalyzerNode effect nodes extend P5SoundEffectNode extract P5SoundBiquad children to separate files source nodes extend P5SoundSourceNode extract P5SoundOscillator children to separate files move P5SoundEnvelope to effect directory move core classes to src directory create P5SoundUtils create P5SoundContext update app.js imports update imports P5SoundAnalyzerNode._inputNode > analyzerInputNode change P5SoundNode.connect console warning fix mixEffectNode output type check fix MixEffect io configuration add TODOs fix audio parameter getters restore P5SoundNode connects to destination by default remove unused import P5SoundDelay uses new P5SoundMixEffectNode.configureWetIO method P5SoundNode invalid node continues instead of returns comment P5SoundNode connection logic update TODOs create P5SoundError P5SoundNode invalid connection attempt error create utilities folder
…on-functionality Abstract Common p5.sound.js Functionality
…b.com/pparocza/p5.sound.js into feature/nodes-default-to-disconnected # Conflicts: # src/nodes/effect/P5SoundReverb.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT - DO NOT MERGE:
Dependent on changes made in PR 59: Abstract Common p5.sound.js Functionality
Changes
P5SoundNodeconstructor no longer connects._outputto audio destination.P5SoundNode.disconnect()defaults to disconnecting from all connected nodes, with optional audioNode argument allowing disconnection from a specific node