Arrange HTML so that the search bar is part of the main element #3398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure I understand the motivation for this change, but this seems like it could be incredibly disruptive to downstream applications are require a lot more overriding to recreate fairly common layout patterns:
|
|
I agree that this may be a challenge for adopters to take on. I believe this provides better semantics for accessibility. I believe this was raised by Darcy when looking at Geoblacklight (see #3252). While implementing this it felt like our existing layouts (with content_for) made this a challenge to implement easily. |
|
Let's close as won't do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3252