do not call deprecated render_search_bar helper #2816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barmintor
force-pushed
the
avoid-deprecated-bl-helper
branch
2 times, most recently
from
dabb49d to
913d7f1
Compare
barmintor
force-pushed
the
avoid-deprecated-bl-helper
branch
from
913d7f1 to
7084c2b
Compare
…search params are permitted
barmintor
force-pushed
the
avoid-deprecated-bl-helper
branch
from
7f67ddd to
47a06f3
Compare
|
@barmintor are you interested in rebasing this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
render_search_barhelper is deprecated. There is also a bug around the deprecation warning in 7.25.1 that will be fixed in a patch release, but avoiding the helper entirely is preferable.