fix: use explicit bool instead of implicit truthy #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described here: https://ansible.readthedocs.io/projects/ansible-core/devel/porting_guides/porting_guide_core_2.19.html#broken-conditionals In Ansible greater than 2.19 implicit truthy is no longer allowed. Therefor we need to use explicit checks. Signed-off-by: Spirit-act <[email protected]>
Spirit-act
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
With Ansible 2.19 implicit truthy is no longer allowed and ansible errors.
Changes
This commit adds explicit checks which returns boolean.
Thoughts
For variables which are defined as:
I have add a check for length, because they count as defined.
Variables which are not clear, for example:
_common_dependenciesI have tested what they can be. In this example
nullor"python3-apt ".(I have no idea why there is a space after
...-apt)For some reason
nullcounts as defined. I have checked it with_common_dependencies is definedSources
https://ansible.readthedocs.io/projects/ansible-core/devel/porting_guides/porting_guide_core_2.19.html#broken-conditionals