Skip to content

Conversation

xie-shujian
Copy link

@xie-shujian xie-shujian commented Sep 8, 2025

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

  • fixes #

Special notes for your reviewer

Particularly user-facing changes

Checklist

Complete these before marking the PR as ready to review:

  • DCO signed
  • The PR title has a summary of the changes and the area they affect
  • The PR body has a summary to reflect any significant (and particularly user-facing) changes introduced by this PR

Signed-off-by: xieshujian <[email protected]>
@xie-shujian xie-shujian requested a review from a team as a code owner September 8, 2025 12:53
@xie-shujian xie-shujian changed the title add file collector to replace filetime collector add file collector to scrape file size and file modify time which can replace filetime collector Sep 10, 2025
@jkroepke jkroepke changed the title add file collector to scrape file size and file modify time which can replace filetime collector file: add file collector to scrape file size and file modify time which can replace filetime collector Oct 11, 2025
@jkroepke
Copy link
Member

Hey @mwimpelberg28

we had a recent chat about breaking changes. Now, what you recommend?

  • Deprecate filetime and merge it into file? (breaking change incoming)
  • Setup a distinct collector named filesize? (maintainer overhead and end-user confusion about 2 similar collectors)

Happy to hear your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants