Relax prometheus_ex requirement #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This will allow for version 4, 5 or any other major breaking change to be included? Wouldn't it be better to just add another or if what you're after is s newer version? This seems like quite a big change to me considering major version 5 is out as of now (I haven't checked the changelog but I'd imagine a bump to v4 and v5 to potentially come with breaking changes) that would go untested in any pipeline?
|
Hi! I understand the what you're saying, The changes in 4.0 and 5.0 seemed relatively small to me and to prevent having to update this file again when another major version is released I added the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it can be used with newer versions and doesn't need to be updated every time