Add a lambda handler for demo-app-posts #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a lambda handler that wraps
demo-app-posts.js. This ALSO refactorsdemo-app-posts.jsto follow the Express.js conventions for how to usereqandres. A result of the refactor is thatdemo-app.jsis broken. The issue there is thatserver.jsis exposing the Pretender convention for returning an array of values, instead of relying on a call tores.jsonin order to respond like in Express.I tried to get
server.jsworking, but I'm not sure that Pretender exposes an api that's friendly to async resolution. I tried the 'manual' resolution method but even that still requires the original handler to return the actual response data and doesn't allow it to be set at the time of resolution (pretender.resolve(req)).