Preserve exception chain in morsel_to_cookie max-age conversion #7059
+18
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves exception handling in the
morsel_to_cookiefunction by preserving the originalValueErrorwhen amax-ageconversion fails, following Python's exception chaining best practices.Changes Made
Modified
src/requests/cookies.py:morsel_to_cookie()to useraise ... from excsyntaxValueErroras the__cause__attribute when raising aTypeErrorAdded test in
tests/test_requests.py:test_max_age_exception_chaining()to verify exception chaining behaviorTypeErroris raised with the correct messageValueErroris preserved in the exception chainMotivation
Previously, when an invalid
max-agevalue was provided, the originalValueErrorfromint()conversion was lost, making debugging more difficult. By using proper exception chaining (raise ... from exc), developers can now:Testing
The new test ensures that:
TypeErroris still raised for invalid max-age valuesValueErroris accessible via the__cause__attributeImpact
TypeError)