-
Notifications
You must be signed in to change notification settings - Fork 8
chore: upgrade next (and other dependencies) #1339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tefkah
commented
Aug 26, 2025
Comment on lines
296
to
298
| await page.goto(decodedUrl); | ||
| await page | ||
| .getByRole("status") | ||
| .getByText("Your email is now verified", { exact: true }) | ||
| .waitFor(); | ||
| await page.getByText("Your email is now verified", { exact: true }).waitFor(); | ||
| await page.waitForURL(fillUrl, { timeout: 5_000 }); |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for some reason this was necessary
3mcd
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
Mostly wanted to do this bc i messed up #1284 and i wanted to get the other updates out of the way before retrying it.
High-level Explanation of PR
Not that many changes, next 15.5/4 does technically allow us to build with
turbopack, but sadly it's not really faster.Secondly,
next15.5 enables node middleware. This could allow us to remove all of the community/user checks inside ofc/[communitySlug]and move that to the middleware instead and store the user/community in cookies.That may not be a good idea tho, i say we leave it for now
should we enable
turbofor buildsfor now, i'll leave it off, as it increases(!) CI build times
locally
Turbo:
standard
ci
standard: 4m 20s
turbo: 4m 40s!! also the bundle size seems to be bigger.
Test Plan
Screenshots (if applicable)
Notes