Skip to content

Conversation

@tefkah
Copy link
Member

@tefkah tefkah commented Aug 20, 2025

Issue(s) Resolved

Mostly wanted to do this bc i messed up #1284 and i wanted to get the other updates out of the way before retrying it.

High-level Explanation of PR

Not that many changes, next 15.5/4 does technically allow us to build with turbopack, but sadly it's not really faster.

Secondly, next 15.5 enables node middleware. This could allow us to remove all of the community/user checks inside of c/[communitySlug] and move that to the middleware instead and store the user/community in cookies.

That may not be a good idea tho, i say we leave it for now

should we enable turbo for builds

for now, i'll leave it off, as it increases(!) CI build times

locally

Turbo:

Executed in   41.69 secs    fish           external
   usr time  122.94 secs  185.00 micros  122.94 secs
   sys time   27.17 secs  785.00 micros   27.17 secs

standard

Executed in   63.36 secs    fish           external
   usr time   90.41 secs    0.23 millis   90.41 secs
   sys time   14.20 secs    2.10 millis   14.20 secs

ci

standard: 4m 20s

turbo: 4m 40s!! also the bundle size seems to be bigger.

Test Plan

Screenshots (if applicable)

Notes

@github-actions
Copy link

github-actions bot commented Aug 20, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-08-26 14:52 UTC

Comment on lines 296 to 298
await page.goto(decodedUrl);
await page
.getByRole("status")
.getByText("Your email is now verified", { exact: true })
.waitFor();
await page.getByText("Your email is now verified", { exact: true }).waitFor();
await page.waitForURL(fillUrl, { timeout: 5_000 });
Copy link
Member Author

@tefkah tefkah Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason this was necessary

@tefkah tefkah requested a review from 3mcd August 26, 2025 14:46
@3mcd 3mcd merged commit e75a05b into main Aug 26, 2025
16 checks passed
@3mcd 3mcd deleted the tfk/upgrade-next branch August 26, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants