Update django-import-export deps #6372
Conversation
dralley
force-pushed
the
django-ie-update
branch
from
c514c3d to
3ca3031
Compare
These have gotten very out of date and it seems like dependabot hasn't worked on them.
dralley
force-pushed
the
django-ie-update
branch
from
3ca3031 to
ce339e4
Compare
| "PyYAML>=5.1.1,<=6.0.2", | ||
| "redis>=4.3,<5.2.2", | ||
| "tablib<3.6.0", | ||
| "tablib>=3.7.0,<3.9.0", |
There was a problem hiding this comment.
Should tablib be a direct dependency at all?
There was a problem hiding this comment.
We import it directly here:
pulpcore/pulpcore/app/tasks/importer.py
Line 16 in d563dec
However as long as django-import-export exists we can probably assume its presence? This requirement was primarily here to avoid new incompatible versions, and presumably that's less of an issue with these newer versions?
There was a problem hiding this comment.
Well turning it into a proper dependency with a proper range also sounds good then.
|
Update: we can't update these packages until a breaking change release. I can verify that there are some changed APIs that are exposed to plugins. |
|
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution! |
|
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution! |
|
Closing in preference for #6973 |
These have gotten very out of date and it seems like dependabot hasn't worked on them.