(MAINT) Allow consumer to bring their own logging. #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliveweir
approved these changes
Sep 5, 2025
eoinmcq
force-pushed
the
AllowDisableServiceLogging
branch
from
32d0bd4 to
02822f6
Compare
eoinmcq
force-pushed
the
AllowDisableServiceLogging
branch
from
02822f6 to
5b2639b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Non logrus consumers which are not using logrus are getting a hybrid of logging formats. Consumer should be able to provide their own logging.
Solution:
Non breaking config flag added which needs to be explicitly specified to turn logging off.
Testing:
Tested by using a consumer with this flag and it is disabled.