Fix include matcher behavior #9455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rspec-expectations recently released v3.13.2, which includes a change to the include matcher (see rspec/rspec-expectations@bd5d306). This change breaks using the splat operator on an array into the include matcher. This commit updates the matcher to iterate over the array instead of using the splat operator.
|
Example of a test failure addressed by this PR: https://github.com/puppetlabs/puppet/actions/runs/10565592677/job/29270718861?pr=9454 |
joshcooper
approved these changes
Aug 27, 2024
|
Should this be backported to 7.x? |
Yeah AFAIK this affects both streams |
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rspec-expectations recently released v3.13.2, which includes a change to the include matcher (see rspec/rspec-expectations@bd5d306).
This change breaks using the splat operator on an array into the include matcher.
This commit updates the matcher to iterate over the array instead of using the splat operator.