(CAT-2353) Puppetcore update #826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A set of changes dedicated to implementing puppetcore into our modules. This update, amongst other changes, removes Puppet 7 support.
LukasAud
requested review from
b4ldr,
bastelfreak,
ekohl,
smortex and
a team
as code owners
bastelfreak
reviewed
Aug 28, 2025
| gem "facterdb", '~> 3.0', require: false if Gem::Requirement.create(['>= 3.0.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup)) | ||
| gem "metadata-json-lint", '~> 4.0', require: false | ||
| gem "rspec-puppet-facts", '~> 4.0', require: false | ||
| gem "json-schema", '< 5.1.1', require: false |
There was a problem hiding this comment.
Why did you pin to 5.1.0 or older? Did I introduce bugs in 5.1.1?
There was a problem hiding this comment.
That was part of the pdk update command run. It was not a manual adjustment. We can look into updating the templates if the 5.1.1 has significantly important updates.
|
Note: All CI failures were GCP related. As discussed internally, we are happy to merge (despite failures) for now while GCP issues are being resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of changes dedicated to implementing puppetcore into our modules. This update, amongst other changes, removes Puppet 7 support.
Checklist