Skip to content

Conversation

williambdean
Copy link
Collaborator

@williambdean williambdean commented Jul 14, 2025

Describe what this PR does / why we need it

Add support for Octo actions with the Snacks picker

TODO:

  • Remove a preview
  • Allow for searching

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

Checklist

  • Passing tests and linting standards
  • Documentation updates in README.md and doc/octo.txt

@williambdean
Copy link
Collaborator Author

Maybe you know how to do this @storopoli ?


return ret
end,
preview = false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this already covering the TODO in the PR body?

Remove a preview

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-07-14 at 2 51 46 PM

I want to remove this "preview" section. Just have the left side

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, the preview = false should be outside pick(...) in the picker.
See https://github.com/folke/snacks.nvim/blob/bc0630e43be5699bb94dadc302c0d21615421d93/docs/picker.md?plain=1#L627

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that reference. Let me try.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't what I am doing the same thing?

@williambdean williambdean added enhancement New feature or request snacks Related to the snacks picker labels Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request snacks Related to the snacks picker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants