-
Notifications
You must be signed in to change notification settings - Fork 190
Add Octo actions
for snacks picker
#1129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Maybe you know how to do this @storopoli ? |
lua/octo/pickers/snacks/provider.lua
Outdated
|
||
return ret | ||
end, | ||
preview = false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this already covering the TODO in the PR body?
Remove a preview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, the preview = false
should be outside pick(...)
in the picker
.
See https://github.com/folke/snacks.nvim/blob/bc0630e43be5699bb94dadc302c0d21615421d93/docs/picker.md?plain=1#L627
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that reference. Let me try.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't what I am doing the same thing?
Describe what this PR does / why we need it
Add support for
Octo actions
with the Snacks pickerTODO:
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews
Checklist