Blakereeves/875 and 761 consolidate gh pr merge logic and use gh run #1144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…merge-logic-and-use-gh-run
… helper function to utils.lua to help determine is pr number
BlakeLReeves
changed the title
Comment on lines
+1849
to
+1852
| if utils.is_number_like(params[1]) then | ||
| pr_number = tostring(params[1]) | ||
| table.remove(params, 1) | ||
| end |
There was a problem hiding this comment.
This should be handled with the run wrapper now
local gh = require "octo.gh"
gh.pr.merge { number }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
This refactors and combines the two merge_pr implementations into one function that uses gh.run. It supports both explicit PR numbers and merging from the current buffer. Flag handling (like merge method, delete, queue) is now cleaner and more predictable.
Does this pull request fix one issue?
Fixes #875
Fixes #761
Describe how you did it
Consolidated merge logic into one function
Replaced Job:new() with gh.run
Cleaned up flag parsing and PR number detection
Describe how to verify it
Run any existing merge commands from a PR buffer (squash, rebase queue, etc.) and confirm they behave as expected.
Special notes for reviews
PR number must either be passed or come from the buffer.
Checklist