feat(snacks): async notifications #862
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored the notifications picker to use a new approach with `gh.run`. - Removed redundant code and streamlined the process of fetching and displaying notifications. - Improved the transformation and formatting of notification items.
Comment on lines
+151
to
+153
| if opts.return_args_only then | ||
| return opts.args | ||
| end |
There was a problem hiding this comment.
Maybe the function should be broken into two.
- Creating the args
- running the command
gh.run with return_args_only seems confusing.
Thoughts?
There was a problem hiding this comment.
Plus this would making debugging / testing a lot easier if we can just swap out
gh.run with gh.create_args but have the same signature / similar
There was a problem hiding this comment.
Hi @tris203, are you still interested in this PR?
There was a problem hiding this comment.
Yes I think it's necessary to move the snackers picker along
However, iirc when I looked the JSON/object parsing was limited to make the best benefit of it
Let me relook at where I got
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Makes the notifications picker use the async system properly
This might need some iteration, the snacks picker doesn't really work with json very well