Relabel nodes in nx_graph with labels

[pbdanny]

No description provided.

[kunwuz]

Thanks so much for the contribution! Could you please elaborate a bit more on the context of this PR? For example, what's the motivation for including relabelling for nx_graph?

[pbdanny]

Hi, i saw the function created node label but not assigned to the label to the the output nx_graph best,

…

On Tue, 21 Oct 2568 BE at 07:28 Yujia Zheng ***@***.***> wrote: *kunwuz* left a comment (py-why/causal-learn#245) <#245 (comment)> Thanks so much for the contribution! Could you please elaborate a bit more on the context of this PR? For example, what's the motivation for including relabelling for nx_graph? — Reply to this email directly, view it on GitHub <#245 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADPL72B7D6XPSRGHSQAPSAT3YV4ZFAVCNFSM6AAAAACJSVI3QOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMRUGIZDQNRRGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[kunwuz]

Aha, thanks for the careful thought. Since later we use integers to add edges, perhaps applying relabeling before that can unintentionally mix integer and string node types, which may lead to potential inconsistency. The existing self.labels mappings already provide a way to reference node names if needed, so we may want to keep the graph structure unchanged here.

[pbdanny]

Understand. Thanks for clarification.

…

On Wed, 22 Oct 2568 BE at 10:47 Yujia Zheng ***@***.***> wrote: *kunwuz* left a comment (py-why/causal-learn#245) <#245 (comment)> Aha, thanks for the careful thought. Since later we use integers to add edges, perhaps applying relabeling before that can unintentionally mix integer and string node types, which may lead to potential inconsistency. The existing self.labels mappings already provide a way to reference node names if needed, so we may want to keep the graph structure unchanged here. — Reply to this email directly, view it on GitHub <#245 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADPL72DDCGVPIQ2AOBVK7VL3Y343NAVCNFSM6AAAAACJSVI3QOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMZQGM4DEMBSHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>