-
-
Notifications
You must be signed in to change notification settings - Fork 686
Make time-based heaviside and modulo inputs explicit t_eval
points with IDAKLUSolver
#4994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4994 +/- ##
===========================================
- Coverage 98.80% 98.80% -0.01%
===========================================
Files 320 320
Lines 27034 27074 +40
===========================================
+ Hits 26711 26750 +39
- Misses 323 324 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, one minor comment
Description
Fixed a bug where including inputs that had a heaviside or modulo as an explicit function of time would fail for the
IDAKLUSolver
. Now, these are added as explicitt_eval
points to stop the solver during integration.Requires pybamm-team/pybammsolvers#35
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commit
nox -s tests
nox -s doctests