Skip to content

Conversation

MarcBerliner
Copy link
Member

@MarcBerliner MarcBerliner commented Apr 24, 2025

Description

Fixed a bug where including inputs that had a heaviside or modulo as an explicit function of time would fail for the IDAKLUSolver. Now, these are added as explicit t_eval points to stop the solver during integration.

Requires pybamm-team/pybammsolvers#35

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link

codecov bot commented Apr 24, 2025

Codecov Report

❌ Patch coverage is 98.14815% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.80%. Comparing base (847723e) to head (a8b98bf).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
src/pybamm/simulation.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4994      +/-   ##
===========================================
- Coverage    98.80%   98.80%   -0.01%     
===========================================
  Files          320      320              
  Lines        27034    27074      +40     
===========================================
+ Hits         26711    26750      +39     
- Misses         323      324       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MarcBerliner MarcBerliner marked this pull request as ready for review September 17, 2025 15:12
@MarcBerliner MarcBerliner requested a review from a team as a code owner September 17, 2025 15:12
valentinsulzer
valentinsulzer previously approved these changes Sep 17, 2025
Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, one minor comment

@MarcBerliner MarcBerliner merged commit a70683d into develop Sep 17, 2025
34 of 38 checks passed
@MarcBerliner MarcBerliner deleted the mdb/idaklu-heaviside-events branch September 17, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants