Skip to content

Conversation

pipliggins
Copy link
Contributor

Description

Input parameters should not be able to be used as initial conditions (see #1261), but a bug was present where if more than one input parameter was provided but not all were used as initial conditions, the error warning could be bypassed.

Fixes #5154

Copy link

codecov bot commented Sep 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.80%. Comparing base (847723e) to head (2d5ea7e).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5191   +/-   ##
========================================
  Coverage    98.80%   98.80%           
========================================
  Files          320      320           
  Lines        27034    27034           
========================================
  Hits         26711    26711           
  Misses         323      323           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rtimms
Copy link
Contributor

rtimms commented Sep 15, 2025

Does this still allow for the case where there is an InputParameter in the initial conditions but there is only one solver? I.e. there is just a dict of inputs not a list of dicts. That case should still work IMO.

@pipliggins
Copy link
Contributor Author

Does this still allow for the case where there is an InputParameter in the initial conditions but there is only one solver? I.e. there is just a dict of inputs not a list of dicts. That case should still work IMO.

Still works; going to edit this PR actually to make it a new feature that a list of input parameters can be provided and the inputs will be distributed correctly (useful for PyBoP).

@pipliggins pipliggins changed the title Fixes input parameters being used in initial conditions Allow lists of input parameters as initial conditions Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: input parameters that affect the initial condition not handled
2 participants