Skip to content

Conversation

@DrSOKane
Copy link
Contributor

Added support for porosity and active material volume fractions that vary in y and z, not just x. It appears to work for the z coordinate ("dimensionality": 1) but the y coordinate appears to get replaced with the StateVector between experiment steps. I tried changing all instances of y in lithium_ion_parameters.py to y_cc but that didn't change anything.

Added an example graded_pouch.py to show that it works in one dimension.

@DrSOKane DrSOKane requested a review from a team as a code owner September 24, 2025 15:40
@DrSOKane DrSOKane marked this pull request as draft September 24, 2025 15:42
@DrSOKane DrSOKane marked this pull request as ready for review November 10, 2025 14:34
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.77%. Comparing base (6ba2cde) to head (f6b8858).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5214   +/-   ##
========================================
  Coverage    98.77%   98.77%           
========================================
  Files          321      321           
  Lines        27727    27733    +6     
========================================
+ Hits         27387    27393    +6     
  Misses         340      340           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants