Skip to content

Fix merge defaults for Dataset._setitem_ and Dataset.update #10651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dhruvak001
Copy link
Contributor

Updates dataset_update_method to use join="left" and compat="override" instead of the expensive defaults join="outer" and compat="broadcast_equals".

@shoyer
Copy link
Member

shoyer commented Aug 21, 2025

The fact that we no tests need to be changed with these new defaults is a little suspicious. It suggests that either we lack test coverage or these defaults aren't actually used in the update() codepath, which uses the internal priority_arg argument.

As discussed in #10585 (comment), a better clean-up might be to get rid of priority_arg?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better "merge" defaults for Dataset.__setitem__ and Dataset.update
2 participants