Skip to content

Conversation

tejaschauhan36912
Copy link
Contributor

Type of Changes

Type
βœ“ πŸ”¨ Refactoring

Description

  • Include invalid type in error message

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice first contribution !

@Pierre-Sassoulas Pierre-Sassoulas added the Enhancement ✨ Improvement to a component label May 31, 2025
@Pierre-Sassoulas Pierre-Sassoulas added this to the 4.0.0 milestone May 31, 2025
Copy link

codecov bot commented May 31, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
βœ… Project coverage is 93.30%. Comparing base (34fbf2e) to head (132b131).
⚠️ Report is 65 commits behind head on main.

Files with missing lines Patch % Lines
astroid/brain/brain_builtin_inference.py 0.00% 1 Missing ⚠️
astroid/brain/brain_namedtuple_enum.py 0.00% 1 Missing ⚠️
astroid/helpers.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2758   +/-   ##
=======================================
  Coverage   93.29%   93.30%           
=======================================
  Files          93       93           
  Lines       11085    11085           
=======================================
+ Hits        10342    10343    +1     
+ Misses        743      742    -1     
Flag Coverage Ξ”
linux 93.17% <25.00%> (+<0.01%) ⬆️
pypy 93.30% <25.00%> (+<0.01%) ⬆️
windows 93.28% <25.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Ξ”
astroid/protocols.py 89.85% <ΓΈ> (ΓΈ)
astroid/brain/brain_builtin_inference.py 92.03% <0.00%> (ΓΈ)
astroid/brain/brain_namedtuple_enum.py 93.88% <0.00%> (ΓΈ)
astroid/helpers.py 96.00% <50.00%> (+0.66%) ⬆️
πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice contribution indeed!

Left one optional comment.

@Pierre-Sassoulas Feel free to merge this! :)

@Pierre-Sassoulas Pierre-Sassoulas merged commit 75ae23e into pylint-dev:main Jun 2, 2025
20 of 21 checks passed
@tejaschauhan36912
Copy link
Contributor Author

Thanks! ❀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement ✨ Improvement to a component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants