minimum python3.10 and pytest8.0 #192
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flub
reviewed
Nov 11, 2025
Member
flub
left a comment
flub
left a comment
There was a problem hiding this comment.
Thanks for the follow-up! LGTM but I think one spelling check was resolved the wrong way.
pytest_timeout.py
Outdated
| """Stop the timeouts when we entered pdb. | ||
| This stops timeouts from triggering when pytest's builting pdb | ||
| This stops timeouts from triggering when pytest's building pdb |
Member
There was a problem hiding this comment.
Suggested change
| This stops timeouts from triggering when pytest's building pdb | |
| This stops timeouts from triggering when pytest's builtin pdb |
Author
There was a problem hiding this comment.
fixed this, thanks
And change black 25.9.0 to 25.11.0
added 4 commits
November 12, 2025 09:50
…nto minimum_python310_and_pytest8 # Conflicts: # .pre-commit-config.yaml # pytest_timeout.py
…nto minimum_python310_and_pytest8
flub
approved these changes
Nov 12, 2025
Member
|
Hum, could you resolve the conflicts that github claims there are? |
Author
|
Hmm, I dont see conflicts in my PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#191 (comment)