feat: make price formatting feed-exponent aware #3136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
fhqvst
force-pushed
the
fhqvst/ui-270-price-formatting-should-be-feed-exponent-aware
branch
from
6c9f78d to
6ec0108
Compare
fhqvst
force-pushed
the
fhqvst/ui-270-price-formatting-should-be-feed-exponent-aware
branch
from
6ec0108 to
62df739
Compare
fhqvst
force-pushed
the
fhqvst/ui-270-price-formatting-should-be-feed-exponent-aware
branch
from
62df739 to
54f0574
Compare
cprussin
approved these changes
Oct 17, 2025
| return useMemo(() => ({ format }), [format]); | ||
| }; | ||
|
|
||
| const formatToSubscriptNumber = (numString: string) => { |
There was a problem hiding this comment.
I think you should consider keeping this formatter, for some cryptos the pricing & CI are very very small fractions and you can have very long streams of zeroes which are very hard to read. This formatter resolves that issue quite nicely and can be applied on top of the exponentBasedFormatter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR we make use of the feed's
exponentin all places where we display its price or confidence intervals.Rationale
While slightly less visually pleasing, this change should prevent users from seeing any inconsistencies as a result of rounding.
How has this been tested?