-
Notifications
You must be signed in to change notification settings - Fork 300
feat: make price formatting feed-exponent aware #3136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: make price formatting feed-exponent aware #3136
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
6c9f78d
to
6ec0108
Compare
6ec0108
to
62df739
Compare
62df739
to
54f0574
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should re-add formatToSubscriptNumber
, but if you feel strongly about shipping this as-is I'm fine with it too
return useMemo(() => ({ format }), [format]); | ||
}; | ||
|
||
const formatToSubscriptNumber = (numString: string) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
In this PR we make use of the feed's
exponent
in all places where we display its price or confidence intervals.Rationale
While slightly less visually pleasing, this change should prevent users from seeing any inconsistencies as a result of rounding.
How has this been tested?