Skip to content

fix puppetdb collector, so it can work on all version of puppetdb #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix puppetdb collector, so it can work on all version of puppetdb #545

wants to merge 3 commits into from

Conversation

ashish1099
Copy link

Old puppetdb.py only handles puppetdb 2x.
This patch will support puppetdb 3.x and puppetdb 4.x

@coveralls
Copy link

coveralls commented Oct 21, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 59.386% when pulling ac1dcba on Obmondo:master into 175a4db on python-diamond:master.

@coveralls
Copy link

coveralls commented Oct 21, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 59.386% when pulling c3373fb on Obmondo:master into 175a4db on python-diamond:master.

@josegonzalez
Copy link
Member

This needs tests for all versions of puppetdb before it can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category: collector collector: puppetdb needs: tests type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashish1099 @coveralls @josegonzalez @shortdudey123