Skip to content

Address some issues from the accessibility milestone #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Address some issues from the accessibility milestone #1562

wants to merge 5 commits into from
+18 −18

Conversation

DragonSenseiGuy
Copy link

@DragonSenseiGuy DragonSenseiGuy commented Sep 2, 2025 •
edited by jb3
Loading

Change log:

  • Added alt-text for the Welcome Video in the homepage
  • Added alt-texts of "" for images that does not affect people with screen-reader in the events page as well as the timeline page
  • Changes alt-texts in the events page form "AoC" to "Advent of Code" so, people who don't have knowledge about it can still know what it is.
  • Change date in the 3.13 release from 2022 to 2024

Fixes

@netlify Netlify
Copy link

netlify bot commented Sep 2, 2025 •
edited
Loading

✅ Deploy Preview for pydis-static ready!

Name Link
🔨 Latest commit bc7b622
🔍 Latest deploy log https://app.netlify.com/projects/pydis-static/deploys/68b77aadf4600f0007be9e39
😎 Deploy Preview https://deploy-preview-1562--pydis-static.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coveralls
Copy link

coveralls commented Sep 2, 2025 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling bc7b622 on DragonSenseiGuy:accessibility
into 023881d on python-discord:main.

@jb3 jb3 changed the title Accessibility Address some issues from the accessibility milestone Sep 2, 2025
This was linked to issues Sep 2, 2025
No alt text for images on events page #1381
Open
Alt text on decorative images on timeline is useless #1406
Open
Non-descriptive alt text on thumbnail on home page #1382
Open
@jchristgit jchristgit self-assigned this Sep 11, 2025
@jchristgit
Copy link
Member

Thank you for the PR! FYI it'll take me a while to review this, I'm a bit swamped with work right now :-)

@DragonSenseiGuy
Copy link
Author

Thank you for the PR! FYI it'll take me a while to review this, I'm a bit swamped with work right now :-)

NP take your time

L3viathan
L3viathan reviewed Sep 20, 2025
View reviewed changes
pydis_site/templates/events/scheduled_events.html
@@ -3,7 +3,7 @@ <h2 class="title is-5" style="margin-bottom: 2rem;">Scheduled events</h2>
<article class="media">
<div class="media-left">
<p class="image is-64x64">
<a href="{% url "events:page" path="code-jams/12" %}"><img class="is-rounded" src="/static/images/events/summer_code_jam_2025/logo.png"></a>
<a href="{% url "events:page" path="code-jams/12" %}"><img class="is-rounded" src="/static/images/events/summer_code_jam_2025/logo.png" alt=""></a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do these three have alt=""? As proper links they should be clickable and with empty alt text it will be ignored by screen readers, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L3viathan L3viathan L3viathan left review comments

@MarkKoz MarkKoz MarkKoz approved these changes

Assignees

@jchristgit jchristgit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alt text on decorative images on timeline is useless Non-descriptive alt text on thumbnail on home page No alt text for images on events page
5 participants
@DragonSenseiGuy @coveralls @jchristgit @L3viathan @MarkKoz