Don't offer a code action for a diagnostic with no diagnostic "code" #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the lsp spec, a diagnostic code, if one exists, should be a number or a string. At least one error message (the help message for missing imports) doesn't include a code, so the parse_line function sets it to "None". When this happens, don't offer a code action for that diagnostic
|
As per the spec, the code is optional and should therefore probably not be included at all if it is not valid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the lsp spec, a diagnostic code, if one exists, should be a number or a string. At least one error message (the help message for missing imports) doesn't include a code, so the parse_line function sets it to "None".
When this happens, don't offer a code action for that diagnostic
#99