Add timezone_abbr property shortcut to tzname() #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenBrown2
force-pushed
the
timezone_abbr
branch
from
f5f80ca to
b628abf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a shortcut property to DateTime objects to get the timezone abbreviation, which can only be gotten from a datetime, since DST will change the result.
I had also wanted to get a list of acceptable abbreviations to add reverse parsing of "zz" in #463, but found it was more complicated than that and even getting the std abbreviation from a
Timezoneobject directly wasn't possible.I've added tests for everywhere
dt.timezone_nameis called, since it's a similar tied property, but if that's too many, I can back them out and just leave the one test intests/datetime/test_getters.pyPull Request Check List