Include/exports.h: Just check for the visibility attribute.
#138036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment alludes to releases that are no longer relevant. Ubuntu 20.04 LTS is no longer supported, but even it has gcc 9. CentOS is in a much different state, but even the spiritual successor rockylinux 8.9 (out of its support window as well) has gcc 8. In short the compilers which do not support the has_attribute directive are no longer themselves supported.
|
All commit authors signed the Contributor License Agreement. |
This comment was marked as resolved.
This comment was marked as resolved.
StanFromIreland
changed the title
Include/exports.h: Just check for the visibility attribute.
StanFromIreland
added
skip news
skip issue
type-refactor
|
We have a bunch of other places where we test for GNU >= 4 and so I don't think only one place is needed to be changed. I would prefer keeping the code as is or update the comment. cc @vstinner |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment alludes to releases that are no longer relevant. Ubuntu 20.04 LTS is no longer supported, but even it has gcc 9. CentOS is in a much different state, but even the spiritual successor rockylinux 8.9 (out of its support window as well) has gcc 8.
In short the compilers that do not support the has_attribute directive are no longer supported.
Build tested on Ubuntu 24.04 and rockylinux 8.9.
Reference:
https://ubuntu.com/about/release-cycle
https://wiki.rockylinux.org/rocky/version/#__tabbed_1_1