-
Notifications
You must be signed in to change notification settings - Fork 338
[mxfp8 moe training] wrap 3d quantize tensor in custom ops and integrate it #3004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danielvegamyhre
wants to merge
1
commit into
danielvegamyhre/stack/69
Choose a base branch
from
danielvegamyhre/stack/71
base: danielvegamyhre/stack/69
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+103
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3004
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a68b868 with merge base f75b251 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
danielvegamyhre
added a commit
that referenced
this pull request
Sep 15, 2025
…ate it stack-info: PR: #3004, branch: danielvegamyhre/stack/71
0ebe1b4
to
785a54a
Compare
This was referenced Sep 15, 2025
danielvegamyhre
added a commit
that referenced
this pull request
Sep 15, 2025
…ate it stack-info: PR: #3004, branch: danielvegamyhre/stack/71
785a54a
to
25ddd79
Compare
25ddd79
to
2c2f7ff
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Sep 15, 2025
…ate it stack-info: PR: #3004, branch: danielvegamyhre/stack/71
danielvegamyhre
added a commit
that referenced
this pull request
Sep 15, 2025
…ate it stack-info: PR: #3004, branch: danielvegamyhre/stack/71
2c2f7ff
to
dc26161
Compare
dc26161
to
e597e40
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Sep 16, 2025
…ate it stack-info: PR: #3004, branch: danielvegamyhre/stack/71
e597e40
to
893167c
Compare
af2c00b
to
47c4e8c
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Sep 17, 2025
…ate it stack-info: PR: #3004, branch: danielvegamyhre/stack/71
danielvegamyhre
added a commit
that referenced
this pull request
Sep 17, 2025
…ate it stack-info: PR: #3004, branch: danielvegamyhre/stack/71
47c4e8c
to
92144cb
Compare
6403a25
to
a60ee11
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Sep 17, 2025
…ate it stack-info: PR: #3004, branch: danielvegamyhre/stack/71
92144cb
to
2e9feb5
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Sep 17, 2025
…ate it stack-info: PR: #3004, branch: danielvegamyhre/stack/71
2e9feb5
to
830da32
Compare
6593572
to
367b67c
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Sep 17, 2025
…ate it stack-info: PR: #3004, branch: danielvegamyhre/stack/71
830da32
to
57ce18f
Compare
367b67c
to
bb8b07f
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Sep 17, 2025
…ate it stack-info: PR: #3004, branch: danielvegamyhre/stack/71
57ce18f
to
61833ea
Compare
…ate it stack-info: PR: #3004, branch: danielvegamyhre/stack/71
61833ea
to
a68b868
Compare
This was referenced Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
moe
mx
topic: not user facing
Use this tag if you don't want this PR to show up in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
[mxfp8 moe training] wrap 3d quantize tensor in custom ops and integrate it
Torchtitan Llama4 e2e training benchmarks
Llama4 debug model
Note there are typically 1-8 experts per device depending on EP degree (for llama4 and DSV3, so these tests simulate 2 and 8 experts per device. We can do real tests using EP once pytorch/torchtitan#1651 is resolved).
seq_len=8192, experts per device = 2
tl;dr:
Config:
seq_len=2048, experts per device = 8
tl;dr:
Llama4 debug model
Config: