Skip to content

Conversation

psiddh
Copy link
Contributor

@psiddh psiddh commented Sep 19, 2025

  • Enable on CI for consistent signals
  • Note that this is interim solution until a proper MCU testing standalone pipeline is ready

Test Plan:

  • examples/arm/run_mcu_models_fvp.sh --target=cortex-m55 --models=qadd,qlinear ════════════════════════════════════════════════════════════════ 🏁 MCU MODEL VALIDATION SUMMARY - TARGET: cortex-m55 ════════════════════════════════════════════════════════════════

qadd : ✅ Passed
qlinear : ✅ Passed

Reviewers:

Subscribers:

Tasks:

Tags:

Summary

[PLEASE REMOVE] See CONTRIBUTING.md's Pull Requests for ExecuTorch PR guidelines.

[PLEASE REMOVE] If this PR closes an issue, please add a Fixes #<issue-id> line.

[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: " label. For a list of available release notes labels, check out CONTRIBUTING.md's Pull Requests.

Test plan

[PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.

@psiddh psiddh requested a review from digantdesai as a code owner September 19, 2025 17:54
Copy link

pytorch-bot bot commented Sep 19, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14440

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 5cc83fe with merge base a548635 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 19, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

"qops": QuantOpTest,
"softmax": SoftmaxModule,
"MultipleOutputsModule": MultipleOutputsModule,
"qlinear": QuantLinearTest,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a TODO for more tests, link the tester RFC thing from @AdrianLundell here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

def __init__(self):
super().__init__()
# Define a simple linear layer
self.linear = torch.nn.Linear(64, 32)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use prime numbers instead of powers of two..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

-m "$model" \
--target="$ETHOS_TARGET" \
--quantize \
--enable_qdq_fusion_pass \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always enable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few internal CI tests were failing, I will fix them first and then enable

- Enable on CI for consistent signals
- Note that this is interim solution until a proper MCU testing
  standalone pipeline is ready

Test Plan:
- examples/arm/run_mcu_models_fvp.sh --target=cortex-m55 --models=qadd,qlinear
════════════════════════════════════════════════════════════════
🏁 MCU MODEL VALIDATION SUMMARY - TARGET: cortex-m55
════════════════════════════════════════════════════════════════

qadd         : ✅ Passed
qlinear      : ✅ Passed

Reviewers:

Subscribers:

Tasks:

Tags:
@psiddh psiddh merged commit c780f05 into pytorch:main Sep 19, 2025
125 of 126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants