Skip to content

Conversation

seemethere
Copy link
Member

Adds the ability to specify patterns that we should skip when doing our evaluation of viable strict.

Adds the ability to specify patterns that we should skip when doing our
evaluation of viable strict.

Signed-off-by: Eli Uriegas <[email protected]>
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 3, 2025
Copy link

vercel bot commented Sep 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Updated (UTC)
torchci Ignored Ignored Sep 3, 2025 6:27pm

@@ -21,6 +21,12 @@ inputs:
considered stable
required: true
type: string
exclude-checks:
Copy link
Contributor

@huydhn huydhn Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be default to an empty string to safely roll out this change, then we can just use --exclude-checks "${{ inputs.requires }}" and update the script logic to handle empty string

@clee2000
Copy link
Contributor

clee2000 commented Sep 3, 2025

isn't the include list a regex? Why not use a regex pattern that excludes the rocm manywheel jobs?

@seemethere
Copy link
Member Author

isn't the include list a regex? Why not use a regex pattern that excludes the rocm manywheel jobs?

This is also true, perhaps this is unnecessary, unsure of how I'd test that it does the negative case though.

@clee2000
Copy link
Contributor

clee2000 commented Sep 3, 2025

isn't the include list a regex? Why not use a regex pattern that excludes the rocm manywheel jobs?

This is also true, perhaps this is unnecessary, unsure of how I'd test that it does the negative case though.

I would just run the script with the new regex pattern and see what it returns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants